versions: Attempt to use Ubuntu 24.04 in packer#2293
Conversation
stevenhorsman
force-pushed
the
test-ubuntu-24.04-base-image
branch
from
14e6d35 to
d622d57
Compare
stevenhorsman
changed the title
ldoktor
left a comment
ldoktor
left a comment
There was a problem hiding this comment.
Looks quite good and seems to work well (only tested x86_64). Could you please split the ubuntu and style changes into 2 commits (in case of reverts)? Also do you know if the versions.yaml is actually used anywhere in the code or is it there just for a reference?
stevenhorsman
force-pushed
the
test-ubuntu-24.04-base-image
branch
from
d622d57 to
5c96f47
Compare
Yes - it's used in Makefile.defaults, so I've updated to make that clearer. |
stevenhorsman
force-pushed
the
test-ubuntu-24.04-base-image
branch
2 times, most recently
from
cc28f9f to
677c0b9
Compare
ldoktor
left a comment
ldoktor
left a comment
There was a problem hiding this comment.
Thanks, seems to cover all places.
There was a problem hiding this comment.
Hi @stevenhorsman lgtm, but I found some focal strings under src/cloud-api-adaptor/podvm/qcow2/rhel|ubuntu/variables.pkr.hcl as default values.
Should we update there too?
See if we can bump to a 24.04 base for the packer podvm image as 20.04 is going EoL Signed-off-by: stevenhorsman <steven@uk.ibm.com>
stevenhorsman
force-pushed
the
test-ubuntu-24.04-base-image
branch
from
677c0b9 to
cf4f196
Compare
Yes - we should - thanks for pointing this out - I did a search for 20.04 and fixed the references I would there, but didn't think to search for focal and replace them, so I've done that now and hopefully the tests will still be good. |
3 participants
See if we can bump to a 24.04 base for the packer
podvm image as 20.04 is going EoL